r70953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70952‎ | r70953 | r70954 >
Date:13:46, 12 August 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r70950
Modified paths:
  • /trunk/extensions/Deployment/Deployment.i18n.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialInstall.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/specials/SpecialInstall.php
@@ -163,7 +163,7 @@
164164
165165 $listHtml = Html::openElement(
166166 'table',
167 - array( 'class' => 'wikitable' )
 167+ array( 'class' => 'wikitable', 'style' => 'width:100%' )
168168 );
169169
170170 $listHtml .= '<tr>' .
@@ -176,7 +176,7 @@
177177 foreach ( $extensions as $extension ) {
178178 $listHtml .= $this->getExtensionForList( $extension );
179179 }
180 -
 180+
181181 $listHtml .= Html::closeElement( 'table' );
182182
183183 $wgOut->addHTML( $listHtml );
@@ -197,14 +197,25 @@
198198 $html .= Html::rawElement(
199199 'td',
200200 array(),
 201+ Html::element( 'b', array(), $extension->name ) .
 202+ '<br />' .
201203 Html::element(
202204 'a',
203205 array(
204206 'href' => $extension->url,
205207 'class' => 'external text'
206208 ),
207 - $extension->name
208 - )
 209+ wfMsg( 'extensionlist-details' )
 210+ ) .
 211+ ' | ' .
 212+ Html::element(
 213+ 'a',
 214+ array(
 215+ 'href' => $extension->download,
 216+ 'class' => 'external text'
 217+ ),
 218+ wfMsg( 'extensionlist-download' )
 219+ )
209220 );
210221
211222 $html .= Html::element( 'td', array(), $extension->version );
Index: trunk/extensions/Deployment/Deployment.i18n.php
@@ -60,7 +60,7 @@
6161 'extensionlist-details' => 'Details',
6262 'extensionlist-download' => 'Download',
6363 'extensionlist-installnow' => 'Install now',
64 - 'extensionlist-createdby' => 'By $1',
 64+ 'extensionlist-createdby' => 'By $1.',
6565
6666 'stability-alpha' => 'Alpha',
6767 'stability-beta' => 'Beta',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70950Work on Special:Installjeroendedauw13:23, 12 August 2010

Status & tagging log