r70944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70943‎ | r70944 | r70945 >
Date:12:58, 12 August 2010
Author:demon
Status:ok
Tags:
Comment:
(bug 24766) Installer is installing all extensions, not just the ones you picked
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -271,8 +271,6 @@
272272 }
273273 }
274274
275 - $this->setVar( '_Extensions', $exts );
276 -
277275 return $exts;
278276 }
279277
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -792,13 +792,14 @@
793793 $this->setVar( 'wgRightsIcon', '' );
794794 }
795795
796 - $exts = $this->parent->getVar( '_Extensions' );
797 - foreach( $exts as $key => $ext ) {
798 - if( !$this->parent->request->getCheck( 'config_ext-' . $ext ) ) {
799 - unset( $exts[$key] );
 796+ $extsAvailable = $this->parent->findExtensions();
 797+ $extsToInstall = array();
 798+ foreach( $extsAvailable as $ext ) {
 799+ if( $this->parent->request->getCheck( 'config_ext-' . $ext ) ) {
 800+ $extsToInstall[] = $ext;
800801 }
801802 }
802 - $this->parent->setVar( '_Extensions', $exts );
 803+ $this->parent->setVar( '_Extensions', $extsToInstall );
803804 return true;
804805 }
805806

Status & tagging log