r70939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70938‎ | r70939 | r70940 >
Date:12:00, 12 August 2010
Author:platonides
Status:ok
Tags:
Comment:
size and sha1 cannot be null in the database layout.
Fixes sqlite parsertests after r70917
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -732,24 +732,28 @@
733733 $user = User::createNew( 'WikiSysop' );
734734 $image = wfLocalFile( Title::makeTitle( NS_FILE, 'Foobar.jpg' ) );
735735 $image->recordUpload2( '', 'Upload of some lame file', 'Some lame file', array(
 736+ 'size' => 12345,
736737 'width' => 1941,
737738 'height' => 220,
738739 'bits' => 24,
739740 'media_type' => MEDIATYPE_BITMAP,
740741 'mime' => 'image/jpeg',
741742 'metadata' => serialize( array() ),
 743+ 'sha1' => sha1(''),
742744 'fileExists' => true
743745 ), $db->timestamp( '20010115123500' ), $user );
744746
745747 # This image will be blacklisted in [[MediaWiki:Bad image list]]
746748 $image = wfLocalFile( Title::makeTitle( NS_FILE, 'Bad.jpg' ) );
747749 $image->recordUpload2( '', 'zomgnotcensored', 'Borderline image', array(
 750+ 'size' => 12345,
748751 'width' => 320,
749752 'height' => 240,
750753 'bits' => 24,
751754 'media_type' => MEDIATYPE_BITMAP,
752755 'mime' => 'image/jpeg',
753756 'metadata' => serialize( array() ),
 757+ 'sha1' => sha1(''),
754758 'fileExists' => true
755759 ), $db->timestamp( '20010115123500' ), $user );
756760 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70917Force $wgContLang to English at the entry point....platonides21:23, 11 August 2010

Status & tagging log