r70923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70922‎ | r70923 | r70924 >
Date:00:29, 12 August 2010
Author:adam
Status:deferred
Tags:
Comment:
more improvements (i hope) to the placement of dropzones when moving a thread
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.js
@@ -1168,6 +1168,10 @@
11691169 // Now one underneath every thread except the drag thread
11701170 $j('.lqt_thread').not( $thread ).each( function() {
11711171 var $curThread = $j( this );
 1172+ // don't put any drop zones under child threads
 1173+ if ( $j.contains( $thread[0], $curThread[0] ) ) return;
 1174+ // don't put it right next to the thread
 1175+ if ( $curThread.find( '.lqt-thread-replies:first > .lqt_thread:last' )[0] == $thread[0] ) return;
11721176 var repliesElement = liquidThreads.getRepliesElement( $curThread );
11731177 repliesElement.contents().filter('.lqt-replies-finish').before( createDropZone( 'now', $curThread.data( 'thread-id' ) ) );
11741178 } );

Status & tagging log