r70920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70919‎ | r70920 | r70921 >
Date:22:05, 11 August 2010
Author:awjrichards
Status:ok
Tags:
Comment:
Resolved non-globalized variables in payflowpro_gateway
Resolved PHP notice that was being thrown on line 515 of payflowpro_gateway.body.php
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -512,7 +512,7 @@
513513 foreach( $data as $key => $value ) {
514514 if( $value == '' || $data['state'] == 'YY' ) {
515515 // ignore fields that are not required
516 - if( $msg[$key] ) {
 516+ if( isset($msg[$key]) ) {
517517 $error[$key] = "**" . wfMsg( 'payflowpro_gateway-error-msg', $msg[$key] ) . "**<br />";
518518 $error_result = '1';
519519 }
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php
@@ -38,6 +38,7 @@
3939 $wgPayflowProUserID = ''; //if one or more users are set up, authorized user ID, else same as VENDOR
4040 $wgPayflowProPassword = ''; //merchant login password
4141
 42+global $wgPayflowGatewayDBserver, $wgPayflowGatewayDBname, $wgPayflowGatewayDBuser, $wgPayflowGatewayDBpassword;
4243 $wgPayflowGatewayDBserver = ( !$wgPayflowGatewayDBserver ) ? $wgDBserver : $wgPayflowGatewayDBserver;
4344 $wgPayflowGatewayDBname = ( !$wgPayflowGatewayDBname ) ? $wgDBname : $wgPayflowGatewayDBname;
4445 $wgPayflowGatewayDBuser = ( !$wgPayflowGatewayDBuser ) ? $wgDBuser : $wgPayflowGatewayDBuser;

Status & tagging log