r70909 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70908‎ | r70909 | r70910 >
Date:18:56, 11 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r24808.
mime is not in getCacheFields(), so $this->mime was never populated at this point (regardless of $info['mime']) and splitMime() always returned unknown.
Modified paths:
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/LocalFile.php
——@@ -377,10 +377,12 @@
378378 $this->$field = $info[$field];
379379 }
380380 }
 381+
381382 // Fix up mime fields
382383 if ( isset( $info['major_mime'] ) ) {
383384 $this->mime = "{$info['major_mime']}/{$info['minor_mime']}";
384385 } elseif ( isset( $info['mime'] ) ) {
 386+ $this->mime = $info['mime'];
385387 list( $this->major_mime, $this->minor_mime ) = self::splitMime( $this->mime );
386388 }
387389 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24808Basic integrated audio/video support, with Ogg implementation....tstarling10:50, 15 August 2007

Status & tagging log