r70748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70747‎ | r70748 | r70749 >
Date:06:50, 9 August 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed copy paste error from last commit and gave siteadmin right sysops.
Modified paths:
  • /trunk/extensions/Deployment/Deployment.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialDashboard.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialInstall.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialUpdate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/specials/SpecialUpdate.php
@@ -42,7 +42,7 @@
4343
4444 // If the user is authorized, display the page, if not, show an error.
4545 if ( $this->userCanExecute( $wgUser ) ) {
46 - $wgOut->addWikiText( $this->getExtensionList() );
 46+
4747 } else {
4848 $this->displayRestrictionError();
4949 }
Index: trunk/extensions/Deployment/specials/SpecialInstall.php
@@ -42,7 +42,7 @@
4343
4444 // If the user is authorized, display the page, if not, show an error.
4545 if ( $this->userCanExecute( $wgUser ) ) {
46 - $wgOut->addWikiText( $this->getExtensionList() );
 46+
4747 } else {
4848 $this->displayRestrictionError();
4949 }
Index: trunk/extensions/Deployment/specials/SpecialDashboard.php
@@ -42,7 +42,7 @@
4343
4444 // If the user is authorized, display the page, if not, show an error.
4545 if ( $this->userCanExecute( $wgUser ) ) {
46 - $wgOut->addWikiText( $this->getExtensionList() );
 46+
4747 } else {
4848 $this->displayRestrictionError();
4949 }
Index: trunk/extensions/Deployment/Deployment.php
@@ -42,6 +42,11 @@
4343 $wgSpecialPages['Update'] = 'SpecialUpdate';
4444 $wgSpecialPageGroups['Update'] = 'administration';
4545
 46+/**
 47+ * The siteadmin permission is needed to access the administration special pages.
 48+ * By default only sysops have this permission.
 49+ */
 50+$wgGroupPermissions['sysop']['siteadmin'] = true;
4651
4752 /**
4853 * Initialization function for the Deployment extension.

Status & tagging log