r70746 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70745‎ | r70746 | r70747 >
Date:06:33, 9 August 2010
Author:huji
Status:ok
Tags:
Comment:
Reverting r70585 since it breaks the whole functionality. Bug 24700 reopened.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -45,7 +45,7 @@
4646
4747 $wgOut->addScriptFile( 'prefs.js' );
4848
49 - if ( $wgRequest->getCheck( 'success' ) && $wgRequest->wasPosted()) {
 49+ if ( $wgRequest->getCheck( 'success' ) ) {
5050 $wgOut->wrapWikiMsg(
5151 "<div class=\"successbox\"><strong>\n$1\n</strong></div><div id=\"mw-pref-clear\"></div>",
5252 'savedprefs'
Index: trunk/phase3/RELEASE-NOTES
@@ -282,8 +282,6 @@
283283 instead of showing an error page
284284 * (bug 24425) Use Database::replace instead of delete/insert in SqlBagOStuff::set
285285 to avoid query errors about duplicate keynames.
286 -* (bug 24700) Update dialog shown when clicking on the special page tab after
287 - saving preferences
288286 * (bug 15470) First letters of filenames are always capitalized by upload JS.
289287 * (bug 21215) NoLocalSettings.php doesn't tolerate rewrite rules
290288

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70585(bug 24700) Update dialog shown when clicking on the special page tab after s...huji19:07, 6 August 2010

Status & tagging log