r70687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70686‎ | r70687 | r70688 >
Date:12:33, 8 August 2010
Author:demon
Status:deferred
Tags:
Comment:
More freeResult() removals
Modified paths:
  • /trunk/extensions/FlaggedRevs/api/ApiQueryFlagged.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/api/ApiQueryOldreviewedpages.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/api/ApiQueryReviewedpages.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/api/ApiQueryUnreviewedpages.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/api/FlaggedRevsApi.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/api/ApiQueryFlagged.php
@@ -56,7 +56,6 @@
5757 $data['pending_since'] = wfTimestamp( TS_ISO_8601, $row->fp_pending_since );
5858 $result->addValue( array( 'query', 'pages', $pageid ), 'flagged', $data );
5959 }
60 - $db->freeResult( $res );
6160 }
6261
6362 public function getCacheMode( $params ) {
Index: trunk/extensions/FlaggedRevs/api/ApiQueryOldreviewedpages.php
@@ -140,7 +140,6 @@
141141 $resultPageSet->processDbRow( $row );
142142 }
143143 }
144 - $db->freeResult( $res );
145144
146145 if ( is_null( $resultPageSet ) ) {
147146 $result = $this->getResult();
Index: trunk/extensions/FlaggedRevs/api/ApiQueryReviewedpages.php
@@ -110,7 +110,6 @@
111111 $resultPageSet->processDbRow( $row );
112112 }
113113 }
114 - $db->freeResult( $res );
115114
116115 if ( is_null( $resultPageSet ) ) {
117116 $result = $this->getResult();
Index: trunk/extensions/FlaggedRevs/api/ApiQueryUnreviewedpages.php
@@ -108,7 +108,6 @@
109109 $resultPageSet->processDbRow( $row );
110110 }
111111 }
112 - $db->freeResult( $res );
113112
114113 if ( is_null( $resultPageSet ) ) {
115114 $result = $this->getResult();
Index: trunk/extensions/FlaggedRevs/api/FlaggedRevsApi.hooks.php
@@ -80,7 +80,6 @@
8181 $data
8282 );
8383 }
84 - $db->freeResult( $res );
8584 return true;
8685 }
8786

Status & tagging log