r70596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70595‎ | r70596 | r70597 >
Date:21:10, 6 August 2010
Author:demon
Status:ok
Tags:
Comment:
Fix for r70571, still have to use $_COOKIE here too, $wgContLang is undefined so far
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
——@@ -305,7 +305,7 @@
306306 session_name( $wgSessionName ? $wgSessionName : $wgCookiePrefix . '_session' );
307307
308308 if( !defined( 'MW_NO_SESSION' ) ) {
309 - if( !$wgCommandLineMode && ( $wgRequest->checkSessionCookie() || $wgRequest->getCookie( 'Token' ) ) ) {
 309+ if( !$wgCommandLineMode && ( $wgRequest->checkSessionCookie() || isset( $_COOKIE[$wgCookiePrefix.'Token'] ) ) ) {
310310 wfIncrStats( 'request_with_session' );
311311 wfSetupSession();
312312 $wgSessionStarted = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70571Cleanup getCookie() and use it all over the place instead of using $_COOKIE d...demon15:00, 6 August 2010

Status & tagging log