r70504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70503‎ | r70504 | r70505 >
Date:15:37, 5 August 2010
Author:catrope
Status:ok
Tags:
Comment:
(bug 24668) Followup to r48165: code accounting for pages being moved OUT of the MediaWiki namespace needs to actually be run when moving OUT of it, not when moving INTO it
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -3135,9 +3135,8 @@
31363136 $u->doUpdate();
31373137 }
31383138 # Update message cache for interface messages
3139 - if ( $nt->getNamespace() == NS_MEDIAWIKI ) {
3140 - global $wgMessageCache;
3141 -
 3139+ global $wgMessageCache;
 3140+ if ( $this->getNamespace() == NS_MEDIAWIKI ) {
31423141 # @bug 17860: old article can be deleted, if this the case,
31433142 # delete it from message cache
31443143 if ( $this->getArticleID() === 0 ) {
@@ -3146,7 +3145,8 @@
31473146 $oldarticle = new Article( $this );
31483147 $wgMessageCache->replace( $this->getDBkey(), $oldarticle->getContent() );
31493148 }
3150 -
 3149+ }
 3150+ if ( $nt->getNamespace() == NS_MEDIAWIKI ) {
31513151 $newarticle = new Article( $nt );
31523152 $wgMessageCache->replace( $nt->getDBkey(), $newarticle->getContent() );
31533153 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48165(bug 17860) Moving a page in the "MediaWiki" namespace using SuppressRedirect...ialex17:15, 8 March 2009

Status & tagging log