r70488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70487‎ | r70488 | r70489 >
Date:06:02, 5 August 2010
Author:reedy
Status:ok
Tags:
Comment:
Followup r70480, per Nikerabbits comment, there '''is''' something to do
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiBase.php
——@@ -662,7 +662,7 @@
663663 switch ( $type ) {
664664 case 'NULL': // nothing to do
665665 break;
666 - case 'string': // nothing to do
 666+ case 'string':
667667 if ( $value === '' ) {
668668 $this->dieUsageMsg( array( 'missingparam', $paramName ) );
669669 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70480Followup r70479...reedy21:21, 4 August 2010

Status & tagging log