r70468 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70467‎ | r70468 | r70469 >
Date:17:42, 4 August 2010
Author:tparscal
Status:ok
Tags:
Comment:
Removed unnessecary terinary expression added in r70355.
Modified paths:
  • /branches/resourceloader/phase3/includes/ResourceLoader.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/ResourceLoader.php
@@ -272,8 +272,8 @@
273273 );
274274 // Mediawiki's WebRequest::getBool is a bit on the annoying side - we need to allow 'true' and 'false' values
275275 // to be converted to boolean true and false
276 - $parameters['user'] = $parameters['user'] === 'true' || $parameters['user'] === true ? true : false;
277 - $parameters['debug'] = $parameters['debug'] === 'true' || $parameters['debug'] === true ? true : false;
 276+ $parameters['user'] = $parameters['user'] === 'true' || $parameters['user'] === true;
 277+ $parameters['debug'] = $parameters['debug'] === 'true' || $parameters['debug'] === true;
278278 // Get the direction from the requested language
279279 if ( !isset( $parameters['dir'] ) ) {
280280 $lang = $wgLang->factory( $parameters['lang'] );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70355Added ability to accept 'true' and 'false' for debug and user parameters, sin...tparscal19:44, 2 August 2010

Status & tagging log