r70404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70403‎ | r70404 | r70405 >
Date:19:37, 3 August 2010
Author:platonides
Status:ok
Tags:
Comment:
If getMasterPos can be safely inherited, so can setFakeMaster
Modified paths:
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -214,6 +214,7 @@
215215 * getSlavePos
216216 * getMasterPos
217217 * getLag
 218+ * setFakeMaster
218219 *
219220 * Generation: (9)
220221 * tableNames
@@ -287,8 +288,7 @@
288289 * select [Done]
289290 *
290291 * Slave/master: 2 / 2
291 - * setFakeSlaveLag [Done]
292 - * setFakeMaster [Done]
 292+ * setFakeSlaveLag [Done] - Where??
293293 *
294294 * Reflection: 5 / 5
295295 * indexInfo [Done]
@@ -1502,11 +1502,6 @@
15031503 public function getStatus( $which="%" ) { $this->installPrint('Not implemented for DB2: getStatus()'); return ''; }
15041504 /**
15051505 * Not implemented
1506 - * @deprecated
1507 - */
1508 - public function setFakeMaster( $enabled = true ) { $this->installPrint('Not implemented for DB2: setFakeMaster()'); }
1509 - /**
1510 - * Not implemented
15111506 * @return string $sql
15121507 * @deprecated
15131508 */

Status & tagging log