r70342 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70341‎ | r70342 | r70343 >
Date:17:44, 2 August 2010
Author:siebrand
Status:resolved (Comments)
Tags:
Comment:
Partially revert r70337. Let's not deprecate methods that are not even removed completely from core (!!!)
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -1930,7 +1930,7 @@
19311931 * @param $prefix String: Optional prefix
19321932 */
19331933 function makeStubLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
1934 - wfDeprecated( __METHOD__ );
 1934+ //wfDeprecated( __METHOD__ );
19351935 return $this->makeColouredLinkObj( $nt, 'stub', $text, $query, $trail, $prefix );
19361936 }
19371937

Follow-up revisions

RevisionCommit summaryAuthorDate
r78366Cleaned up r70342 and r70343: removed commented-out code.tstarling11:11, 14 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70337Check the link color (stub, redirect) on just one place....platonides15:53, 2 August 2010

Comments

#Comment by Platonides (talk | contribs)   18:27, 2 August 2010

This was not added in r70337. You probably wanted to undeprecate makeSizeLinkObj (not used in core any more) or makeColouredLinkObj (deprecated in phpdoc, but there's a call from non-deprecated LinkHolderArray that I missed).

#Comment by Platonides (talk | contribs)   18:28, 2 August 2010

The one at makeColouredLinkObj was commented in r70343

#Comment by Tim Starling (talk | contribs)   11:10, 14 December 2010

That wasn't a revert, reverting would involve removing the code properly, without leaving a mess behind.

Status & tagging log