r70335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70334‎ | r70335 | r70336 >
Date:14:33, 2 August 2010
Author:platonides
Status:ok
Tags:
Comment:
A <pre> and new lines is not the best element for the Selenium output.
But at least do not use <font>
Modified paths:
  • /trunk/phase3/maintenance/tests/selenium/SeleniumTestHTMLLogger.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/selenium/SeleniumTestHTMLLogger.php
@@ -3,7 +3,7 @@
44 class SeleniumTestHTMLLogger {
55 public function setHeaders() {
66 global $wgOut;
7 - $wgOut->addHeadItem( 'selenium', '<style>
 7+ $wgOut->addHeadItem( 'selenium', '<style type="text/css">
88 .selenium pre {
99 overflow-x: auto; /* Use horizontal scroller if needed; for Firefox 2, not needed in Firefox 3 */
1010 white-space: pre-wrap; /* css-3 */
@@ -13,6 +13,7 @@
1414 /* width: 99%; */
1515 word-wrap: break-word; /* Internet Explorer 5.5+ */
1616 }
 17+ .selenium-success { color: green }
1718 </style>' );
1819 }
1920
@@ -20,11 +21,11 @@
2122 global $wgOut;
2223 $out = '';
2324 if ( $mode == SeleniumTestSuite::RESULT_OK ) {
24 - $out .= '<font color="green">';
 25+ $out .= '<span class="selenium-success">';
2526 }
2627 $out .= htmlspecialchars( $message );
2728 if ( $mode == SeleniumTestSuite::RESULT_OK ) {
28 - $out .= '</font>';
 29+ $out .= '</span>';
2930 }
3031 if ( $mode != SeleniumTestSuite::CONTINUE_LINE ) {
3132 $out .= '<br />';

Status & tagging log