r70254 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70253‎ | r70254 | r70255 >
Date:04:37, 1 August 2010
Author:aaron
Status:ok
Tags:
Comment:
* r69824: Removed require() that is not needed anymore
* Comment fixes
Modified paths:
  • /trunk/extensions/FlaggedRevs/maintenance/tests/FRInclusionManagerTest.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/maintenance/tests/FRUserCountersTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/maintenance/tests/FRUserCountersTest.php
@@ -1,7 +1,5 @@
22 <?php
33
4 -require_once 'PHPUnit\Framework\TestCase.php';
5 -
64 class FRUserCountersTest extends PHPUnit_Framework_TestCase {
75 /**
86 * Prepares the environment before running a test.
Index: trunk/extensions/FlaggedRevs/maintenance/tests/FRInclusionManagerTest.php
@@ -1,7 +1,5 @@
22 <?php
33
4 -require_once 'PHPUnit\Framework\TestCase.php';
5 -
64 class FRInclusionManagerTest extends PHPUnit_Framework_TestCase {
75 /* starting input */
86 protected static $inputTemplates = array(
@@ -16,7 +14,7 @@
1715 'Filele' => array('ts' => 0, 'sha1' => ''),
1816 '0' => array('ts' => '20000203101350', 'sha1' => 'ae33'),
1917 );
20 - /* output to test against (test# => <NS,dbkey,expected rev ID>) */
 18+ /* output to test against (<test,NS,dbkey,expected rev ID>) */
2119 protected static $reviewedOutputTemplates = array(
2220 array( "Output version when given '1224'", 10, 'XX', 1242 ),
2321 array( "Output version when given '0'", 10, 'YY', 0 ),
@@ -35,7 +33,7 @@
3634 array( "Output version when given 13", 0, '0', 13 ),
3735 array( "Output version when not given", 0, 'NotexistsPage1111', 0 ),
3836 );
39 - /* output to test against (test# => <dbkey,expected TS,expected sha1>) */
 37+ /* output to test against (<test,dbkey,expected TS,expected sha1>) */
4038 protected static $reviewedOutputFiles = array(
4139 array( "Output version when given '20100405192110'/'abc1'",
4240 'FileXX', '20100405192110', 'abc1'),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69824Added some experimental code testsaaron04:48, 24 July 2010

Status & tagging log