r70233 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70232‎ | r70233 | r70234 >
Date:20:04, 31 July 2010
Author:reedy
Status:ok
Tags:
Comment:
version_compare( $wgVersion, '1.15.999', '<=' ) to version_compare( $wgVersion, '1.16', '<' )

Bit of normalisation (usage of the other already there)

Add a couple of braces
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
@@ -123,7 +123,7 @@
124124 $fields = array( 'wl_user', 'ums_user', 'ums_read_timestamp' );
125125
126126 global $wgVersion;
127 - if ( version_compare( $wgVersion, '1.15.999', '<=' ) ) {
 127+ if ( version_compare( $wgVersion, '1.16', '<' ) ) {
128128 $oldPrefCompat = true;
129129
130130 $tables[] = 'user';
@@ -175,7 +175,7 @@
176176
177177 global $wgVersion;
178178
179 - if ( version_compare( $wgVersion, '1.15.999', '<=' ) ) {
 179+ if ( version_compare( $wgVersion, '1.16', '<' ) ) {
180180 $decodedOptions = self::decodeUserOptions( $row->user_options );
181181
182182 $wantsTalkNotification = !isset( $decodedOptions['lqtnotifytalk'] );
@@ -392,8 +392,9 @@
393393
394394 $cval = $wgMemc->get( wfMemcKey( 'lqt-new-messages-count', $user->getId() ) );
395395
396 - if ( $cval )
 396+ if ( $cval ) {
397397 return $cval;
 398+ }
398399
399400 $dbr = wfGetDB( DB_SLAVE );
400401

Status & tagging log