r70231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70230‎ | r70231 | r70232 >
Date:19:53, 31 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Move a few braces noticed while doing CR
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
@@ -197,8 +197,7 @@
198198 /* Set up internal members based upon params. */
199199 $this->initProperties( $prop );
200200
201 - if ( $this->fld_patrolled && !$wgUser->useRCPatrol() && !$wgUser->useNPPatrol() )
202 - {
 201+ if ( $this->fld_patrolled && !$wgUser->useRCPatrol() && !$wgUser->useNPPatrol() ) {
203202 $this->dieUsage( 'You need the patrol right to request the patrolled flag', 'permissiondenied' );
204203 }
205204
@@ -219,8 +218,7 @@
220219 $this->addFieldsIf( 'rc_log_type', $this->fld_loginfo );
221220 $this->addFieldsIf( 'rc_log_action', $this->fld_loginfo );
222221 $this->addFieldsIf( 'rc_params', $this->fld_loginfo );
223 - if ( $this->fld_redirect || isset( $show['redirect'] ) || isset( $show['!redirect'] ) )
224 - {
 222+ if ( $this->fld_redirect || isset( $show['redirect'] ) || isset( $show['!redirect'] ) ) {
225223 $this->addTables( 'page' );
226224 $this->addJoinConds( array( 'page' => array( 'LEFT JOIN', array( 'rc_namespace=page_namespace', 'rc_title=page_title' ) ) ) );
227225 $this->addFields( 'page_is_redirect' );
Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
@@ -186,8 +186,7 @@
187187 if ( !is_null( $show ) ) {
188188 $show = array_flip( $show );
189189 if ( ( isset( $show['minor'] ) && isset( $show['!minor'] ) )
190 - || ( isset( $show['patrolled'] ) && isset( $show['!patrolled'] ) ) )
191 - {
 190+ || ( isset( $show['patrolled'] ) && isset( $show['!patrolled'] ) ) ) {
192191 $this->dieUsageMsg( array( 'show' ) );
193192 }
194193
@@ -211,8 +210,7 @@
212211 ) );
213212
214213 if ( isset( $show['patrolled'] ) || isset( $show['!patrolled'] ) ||
215 - $this->fld_patrolled )
216 - {
 214+ $this->fld_patrolled ) {
217215 if ( !$wgUser->useRCPatrol() && !$wgUser->useNPPatrol() ) {
218216 $this->dieUsage( 'You need the patrol right to request the patrolled flag', 'permissiondenied' );
219217 }

Status & tagging log