r70225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70224‎ | r70225 | r70226 >
Date:18:29, 31 July 2010
Author:platonides
Status:ok
Tags:
Comment:
Remove useless $DP.
Roan confirmed that there was no hidden usage on wmf-config/

The '$DP = $IP;' in CommonSettings.php:94 should be removed, too.
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -740,7 +740,6 @@
741741
742742 putenv( 'wikilang=' . $lang );
743743
744 - $DP = $IP;
745744 ini_set( 'include_path', ".:$IP:$IP/includes:$IP/languages:$IP/maintenance" );
746745
747746 if ( $lang == 'test' && $site == 'wikipedia' ) {
@@ -753,7 +752,7 @@
754753 * @return String
755754 */
756755 public function loadSettings() {
757 - global $wgWikiFarm, $wgCommandLineMode, $IP, $DP;
 756+ global $wgWikiFarm, $wgCommandLineMode, $IP;
758757
759758 $wgWikiFarm = false;
760759 if ( isset( $this->mOptions['conf'] ) ) {
@@ -775,7 +774,6 @@
776775 "must exist and be readable in the source directory.", true );
777776 }
778777 $wgCommandLineMode = true;
779 - $DP = $IP;
780778 return $settingsFile;
781779 }
782780

Status & tagging log