r70194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70193‎ | r70194 | r70195 >
Date:17:26, 30 July 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Title is no longer public member in WikiPageMessageGroup
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -740,23 +740,23 @@
741741 $key = $this->page;
742742
743743 // TODO: encapsulate somewhere
744 - $page = TranslatablePage::newFromTitle( $this->group->title );
 744+ $page = TranslatablePage::newFromTitle( $this->group->getTitle() );
745745 $rev = $page->getTransRev( "$key/$code" );
746746 $latest = $page->getMarkedTag();
747747 if ( $rev === $latest ) {
748748 return null;
749749 }
750750
751 - $oldpage = TranslatablePage::newFromRevision( $this->group->title, $rev );
 751+ $oldpage = TranslatablePage::newFromRevision( $this->group->getTitle(), $rev );
752752 $oldtext = $newtext = null;
753753 foreach ( $oldpage->getParse()->getSectionsForSave() as $section ) {
754 - if ( $this->group->title->getPrefixedDBKey() . '/' . $section->id === $key ) {
 754+ if ( $this->group->getTitle()->getPrefixedDBKey() . '/' . $section->id === $key ) {
755755 $oldtext = $section->getTextForTrans();
756756 }
757757 }
758758
759759 foreach ( $page->getParse()->getSectionsForSave() as $section ) {
760 - if ( $this->group->title->getPrefixedDBKey() . '/' . $section->id === $key ) {
 760+ if ( $this->group->getTitle()->getPrefixedDBKey() . '/' . $section->id === $key ) {
761761 $newtext = $section->getTextForTrans();
762762 }
763763 }

Status & tagging log