r70167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70166‎ | r70167 | r70168 >
Date:19:09, 29 July 2010
Author:simetrical
Status:ok
Tags:
Comment:
Two new parser tests related to bug 6200

A patch posted there caused two parser tests for <center> to fail, but
none for <blockquote>, despite making a similar change to both elements.
I've added similar tests for <blockquote> so that they'll fail if a
similar patch is attempted that changes only <blockquote> behavior and
not <center> too.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
——@@ -370,7 +370,22 @@
371371
372372 !! end
373373
 374+# Expected output in the following test is not really expected (there should be
 375+# <pre> in the output) -- it's only testing for well-formedness.
374376 !! test
 377+Bug 6200: Preformatted in <blockquote>
 378+!! input
 379+<blockquote>
 380+ Blah
 381+</blockquote>
 382+!! result
 383+<blockquote>
 384+ Blah
 385+</blockquote>
 386+
 387+!! end
 388+
 389+!! test
375390 <pre> with attributes (bug 3202)
376391 !! input
377392 <pre style="background: blue; color:white">Bluescreen of WikiDeath</pre>
——@@ -7044,7 +7059,30 @@
70457060 </p>
70467061 !! end
70477062
 7063+# Expected output in the following test is not necessarily expected (there
 7064+# should probably be <p> tags inside the <blockquote> in the output) -- it's
 7065+# only testing for well-formedness.
70487066 !! test
 7067+Bug 6200: blockquotes and paragraph formatting
 7068+!! input
 7069+<blockquote>
 7070+foo
 7071+</blockquote>
 7072+
 7073+bar
 7074+
 7075+ baz
 7076+!! result
 7077+<blockquote>
 7078+foo
 7079+</blockquote>
 7080+<p>bar
 7081+</p>
 7082+<pre>baz
 7083+</pre>
 7084+!! end
 7085+
 7086+!! test
70497087 Bug 8293: Use of center tag ruins paragraph formatting
70507088 !! input
70517089 <center>

Follow-up revisions

RevisionCommit summaryAuthorDate
r103933Add test case described by Vitaliy Filippov in bug 6200.gwicke18:14, 22 November 2011

Status & tagging log