r70157 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70156‎ | r70157 | r70158 >
Date:18:36, 29 July 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Added deployment documentation group
Modified paths:
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/PostgresInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -3,6 +3,9 @@
44 /*
55 * Class for handling database updates. Roughly based off of updaters.inc, with
66 * a few improvements :)
 7+ *
 8+ * @ingroup Deployment
 9+ * @since 1.17
710 */
811 abstract class DatabaseUpdater {
912
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -1,9 +1,13 @@
22 <?php
33
44 /**
5 - * Mysql update list and mysql-specific update functions
 5+ * Mysql update list and mysql-specific update functions.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
69 */
710 class MysqlUpdater extends DatabaseUpdater {
 11+
812 protected function getCoreUpdateList() {
913 return array(
1014 '1.2' => array(
Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -3,6 +3,7 @@
44 /**
55 * Class for the core installer web interface.
66 *
 7+ * @ingroup Deployment
78 * @since 1.17
89 */
910 class WebInstaller extends CoreInstaller {
Index: trunk/phase3/includes/installer/Installer.php
@@ -1,11 +1,18 @@
22 <?php
33
44 /**
 5+ * This documentation group collects source code files with deployment functionality.
 6+ *
 7+ * @defgroup Deployment Deployment
 8+ */
 9+
 10+/**
511 * Base installer class.
612 *
713 * This class provides the base for installation and update functionality
814 * for both MediaWiki core and extensions.
915 *
 16+ * @ingroup Deployment
1017 * @since 1.17
1118 */
1219 abstract class Installer {
Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -4,6 +4,7 @@
55 * Base core installer class.
66 * Handles everything that is independent of user interface.
77 *
 8+ * @ingroup Deployment
89 * @since 1.17
910 */
1011 abstract class CoreInstaller extends Installer {
Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -7,6 +7,9 @@
88 * the interests of separation of concerns: if we used a subclass, there would be
99 * quite a lot of things you could do in OutputPage that would break the installer,
1010 * that wouldn't be immediately obvious.
 11+ *
 12+ * @ingroup Deployment
 13+ * @since 1.17
1114 */
1215 class WebInstallerOutput {
1316
Index: trunk/phase3/includes/installer/SqliteInstaller.php
@@ -1,5 +1,11 @@
22 <?php
33
 4+/**
 5+ * Class for setting up the MediaWiki database using SQLLite.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
 9+ */
410 class SqliteInstaller extends DatabaseInstaller {
511
612 protected $globalNames = array(
Index: trunk/phase3/includes/installer/DatabaseInstaller.php
@@ -2,6 +2,9 @@
33
44 /**
55 * Base class for DBMS-specific installation helper classes.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
69 */
710 abstract class DatabaseInstaller {
811
Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -1,5 +1,11 @@
22 <?php
33
 4+/**
 5+ * Class for manipulating LocalSettings.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
 9+ */
410 class LocalSettingsGenerator {
511
612 private $extensions = array();
Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -1,5 +1,11 @@
22 <?php
33
 4+/**
 5+ * Class for setting up the MediaWiki database using MySQL.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
 9+ */
410 class MysqlInstaller extends DatabaseInstaller {
511
612 protected $globalNames = array(
@@ -60,10 +66,10 @@
6167 }
6268
6369 public function submitConnectForm() {
64 - // Get variables from the request
 70+ // Get variables from the request.
6571 $newValues = $this->setVarsFromRequest( array( 'wgDBserver', 'wgDBname', 'wgDBprefix' ) );
6672
67 - // Validate them
 73+ // Validate them.
6874 $status = Status::newGood();
6975 if ( !strlen( $newValues['wgDBname'] ) ) {
7076 $status->fatal( 'config-missing-db-name' );
Index: trunk/phase3/includes/installer/OracleInstaller.php
@@ -1,5 +1,11 @@
22 <?php
33
 4+/**
 5+ * Class for setting up the MediaWiki database using Oracle.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
 9+ */
410 class OracleInstaller extends DatabaseInstaller {
511
612 protected $globalNames = array(
Index: trunk/phase3/includes/installer/PostgresInstaller.php
@@ -1,5 +1,11 @@
22 <?php
33
 4+/**
 5+ * Class for setting up the MediaWiki database using Postgres.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
 9+ */
410 class PostgresInstaller extends DatabaseInstaller {
511
612 protected $globalNames = array(
Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -3,6 +3,7 @@
44 /**
55 * Class for the core installer command line interface.
66 *
 7+ * @ingroup Deployment
78 * @since 1.17
89 */
910 class CliInstaller extends CoreInstaller {
Index: trunk/phase3/includes/installer/SqliteUpdater.php
@@ -1,8 +1,13 @@
22 <?php
 3+
34 /**
4 - * Sqlite
 5+ * Class for handling updates to Sqlite databases.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
59 */
610 class SqliteUpdater extends DatabaseUpdater {
 11+
712 protected function getCoreUpdateList() {
813 return array(
914 '1.14' => array(
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -2,6 +2,9 @@
33
44 /**
55 * Abstract class to define pages for the web installer.
 6+ *
 7+ * @ingroup Deployment
 8+ * @since 1.17
69 */
710 abstract class WebInstallerPage {
811

Status & tagging log