r70153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70152‎ | r70153 | r70154 >
Date:18:25, 29 July 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Style and doc improvements
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -160,7 +160,7 @@
161161 'icon' => '{$wgStylePath}/common/images/gnu-fdl.png',
162162 ),
163163 'cc-choose' => array(
164 - // details will be filled in by the selector
 164+ // Details will be filled in by the selector.
165165 'url' => '',
166166 'icon' => '',
167167 'text' => '',
Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -1,6 +1,7 @@
22 <?php
33
44 class LocalSettingsGenerator {
 5+
56 private $extensions = array();
67 private $values = array();
78 private $configPath = '';
@@ -64,6 +65,13 @@
6566 $this->values['wgEmergencyContact'] = $this->values['wgPasswordSender'];
6667 }
6768
 69+ /**
 70+ * Returns the escaped version of a string of php code.
 71+ *
 72+ * @param $string String
 73+ *
 74+ * @return String
 75+ */
6876 public static function escapePhpString( $string ) {
6977 if ( is_array( $string ) || is_object( $string ) ) {
7078 return false;
@@ -85,7 +93,8 @@
8694 /**
8795 * Return the full text of the generated LocalSettings.php file,
8896 * including the extensions
89 - * @returns String
 97+ *
 98+ * @return String
9099 */
91100 public function getText() {
92101 $localSettings = $this->getDefaultText();
@@ -101,6 +110,9 @@
102111 return $localSettings;
103112 }
104113
 114+ /**
 115+ * @return String
 116+ */
105117 private function buildMemcachedServerList() {
106118 $servers = $this->values['_MemCachedServers'];
107119
@@ -119,6 +131,9 @@
120132 }
121133 }
122134
 135+ /**
 136+ * @return String
 137+ */
123138 private function getDefaultText() {
124139 if( !$this->values['wgImageMagickConvertCommand'] ) {
125140 $this->values['wgImageMagickConvertCommand'] = '/usr/bin/convert';

Status & tagging log