r70130 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70129‎ | r70130 | r70131 >
Date:09:32, 29 July 2010
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up r60277: Do not return BEFORE_PROCESSING, but void instead.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -432,7 +432,10 @@
433433 // Deprecated backwards compatibility hook
434434 if( !wfRunHooks( 'UploadForm:BeforeProcessing', array( &$this ) ) ) {
435435 wfDebug( "Hook 'UploadForm:BeforeProcessing' broke processing the file.\n" );
436 - return array( 'status' => UploadBase::BEFORE_PROCESSING );
 436+ // Return without notifying the user of an error. This sucks, but
 437+ // this was the previous behaviour as well, and as this hook is
 438+ // deprecated we're not going to do anything about it.
 439+ return;
437440 }
438441
439442

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60277Restore hooks UploadForm:initial and UploadForm:BeforeProcessing removed in r...btongminh19:57, 21 December 2009

Status & tagging log