r70117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70116‎ | r70117 | r70118 >
Date:21:57, 28 July 2010
Author:adam
Status:ok
Tags:
Comment:
Fix for bug 24350
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Modules/SimpleSearch/SimpleSearch.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/Vector/Modules/SimpleSearch/SimpleSearch.js
@@ -9,7 +9,10 @@
1010
1111 $j(document).ready( function() {
1212 // Only use this function in conjuction with the Vector skin
13 - if( !wgVectorEnabledModules.simplesearch || wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) {
 13+ if( !wgVectorEnabledModules.simplesearch ||
 14+ wgVectorPreferences.simplesearch.disablesuggest ||
 15+ !wgVectorPreferences.simplesearch.enable ||
 16+ skin != 'vector' ) {
1417 return true;
1518 }
1619 var mod = {
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -17,13 +17,13 @@
1818 array( 'src' => 'Modules/ExpandableSearch/ExpandableSearch.js', 'version' => 5 ),
1919 array( 'src' => 'Modules/EditWarning/EditWarning.js', 'version' => 10 ),
2020 array( 'src' => 'Modules/FooterCleanup/FooterCleanup.js', 'version' => 5 ),
21 - array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 25 ),
 21+ array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 26 ),
2222 ),
2323 'combined' => array(
24 - array( 'src' => 'Vector.combined.js', 'version' => 69 ),
 24+ array( 'src' => 'Vector.combined.js', 'version' => 70 ),
2525 ),
2626 'minified' => array(
27 - array( 'src' => 'Vector.combined.min.js', 'version' => 70 ),
 27+ array( 'src' => 'Vector.combined.min.js', 'version' => 71 ),
2828 ),
2929 );
3030 static $modules = array(
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -519,7 +519,10 @@
520520
521521 $j(document).ready( function() {
522522 // Only use this function in conjuction with the Vector skin
523 - if( !wgVectorEnabledModules.simplesearch || wgVectorPreferences.simplesearch.disablesuggest || skin != 'vector' ) {
 523+ if( !wgVectorEnabledModules.simplesearch ||
 524+ wgVectorPreferences.simplesearch.disablesuggest ||
 525+ !wgVectorPreferences.simplesearch.enable ||
 526+ skin != 'vector' ) {
524527 return true;
525528 }
526529 var mod = {
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js
@@ -24,7 +24,7 @@
2525 $j('#editpage-copywarn').add('.editOptions').wrapAll('<div id="editpage-bottom"></div>');$j('#wpSummary').data('hint',$j('#wpSummaryLabel span small').remove().text().replace(/\)|\(/g,'')).change(function(){if($j(this).val().length==0){$j(this).addClass('inline-hint').val($j(this).data('hint'));}else{$j(this).removeClass('inline-hint');}}).focus(function(){if($j(this).val()==$j(this).data('hint')){$j(this).removeClass('inline-hint').val("");}}).blur(function(){$j(this).trigger('change');}).trigger('change');$j('#wpSummary').add('.editCheckboxes').wrapAll('<div id="editpage-summary-fields"></div>');$j('#editpage-specialchars').remove();var transclusionCount=$j('.templatesUsed ul li').size();$j('.templatesUsed ul').wrap('<div id="transclusions-list" class="collapsible-list collapsed"></div>').parent().prepend('<label>This page contains <a href="http://en.wikipedia.org/wiki/transclusion">transclusions</a> of <strong>'
2626 +transclusionCount
2727 +'</strong> other pages.</label>');$j('.mw-templatesUsedExplanation').remove();$j('.collapsible-list label').click(function(){$j(this).parent().toggleClass('expanded').toggleClass('collapsed').find('ul').slideToggle('fast');return false;}).trigger('click');$j('#wpPreview, #wpDiff, .editHelp, #editpage-specialchars').remove();$j('#mw-editform-cancel').remove().appendTo('.editButtons');});if(wgVectorEnabledModules.simplesearch&&skin=='vector'&&typeof os_autoload_inputs!=='undefined'&&os_autoload_forms!=='undefined'){os_autoload_inputs=[];os_autoload_forms=[];}
28 -$j(document).ready(function(){if(!wgVectorEnabledModules.simplesearch||wgVectorPreferences.simplesearch.disablesuggest||skin!='vector'){return true;}
 28+$j(document).ready(function(){if(!wgVectorEnabledModules.simplesearch||wgVectorPreferences.simplesearch.disablesuggest||!wgVectorPreferences.simplesearch.enable||skin!='vector'){return true;}
2929 var mod={'browsers':{'ltr':{'opera':[['>=',9.6]],'docomo':false,'blackberry':false,'ipod':false,'iphone':false},'rtl':{'opera':[['>=',9.6]],'docomo':false,'blackberry':false,'ipod':false,'iphone':false}}};if(!$j.wikiEditor.isSupported(mod)){return true;}
3030 if('placeholder'in document.createElement('input')){$j('div#simpleSearch > input#searchInput').attr('placeholder',mw.usability.getMsg('vector-simplesearch-search'));}else{$j('div#simpleSearch > input#searchInput').each(function(){var $input=$j(this);$input.bind('blur',function(){if($input.val().length==0){$input.val(mw.usability.getMsg('vector-simplesearch-search')).addClass('placeholder');}}).bind('focus',function(){if($input.hasClass('placeholder')){$input.val('').removeClass('placeholder');}}).parents('form').bind('submit',function(){$input.trigger('focus');});if($input.val()==''){$input.trigger('blur');}});}
3131 $j('#searchInput, #searchInput2, #powerSearchText, #searchText').suggestions({fetch:function(query){var $this=$j(this);var request=$j.ajax({url:wgScriptPath+'/api.php',data:{'action':'opensearch','search':query,'namespace':0,'suggest':''},dataType:'json',success:function(data){$this.suggestions('suggestions',data[1]);}});$j(this).data('request',request);},cancel:function(){var request=$j(this).data('request');if(request&&typeof request.abort=='function'){request.abort();$j(this).removeData('request');}},result:{select:function($textbox){$textbox.closest('form').submit();}},delay:120,positionFromLeft:$j('body').is('.rtl'),highlightInput:true}).bind('paste cut',function(e){$j(this).trigger('keypress');});$j('#searchInput').suggestions({result:{select:function($textbox){$textbox.closest('form').submit();}},special:{render:function(query){if($j(this).children().size()==0){$j(this).show()
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -54,7 +54,7 @@
5555 'base_sets' => array(
5656 'raw' => array(
5757 // Common UsabilityInitiative funtions
58 - array( 'src' => 'js/usability.js', 'version' => 5 ),
 58+ array( 'src' => 'js/usability.js', 'version' => 6 ),
5959
6060 // Core functionality of extension scripts
6161 array( 'src' => 'js/plugins/jquery.async.js', 'version' => 3 ),
@@ -83,10 +83,10 @@
8484 array( 'src' => 'js/thirdparty/contentCollector.js', 'version' => 2 ),
8585 ),
8686 'combined' => array(
87 - array( 'src' => 'js/plugins.combined.js', 'version' => 455 ),
 87+ array( 'src' => 'js/plugins.combined.js', 'version' => 456 ),
8888 ),
8989 'minified' => array(
90 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 476 ),
 90+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 477 ),
9191 ),
9292 ),
9393 );
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -16,17 +16,17 @@
1717 array( 'src' => 'Modules/Preview/Preview.js', 'version' => 9 ),
1818 array( 'src' => 'Modules/PreviewDialog/PreviewDialog.js', 'version' => 2 ),
1919 array( 'src' => 'Modules/Publish/Publish.js', 'version' => 6 ),
20 - array( 'src' => 'Modules/Toc/Toc.js', 'version' => 9 ),
 20+ array( 'src' => 'Modules/Toc/Toc.js', 'version' => 10 ),
2121 array( 'src' => 'Modules/Toolbar/Toolbar.js', 'version' => 104 ),
2222 array( 'src' => 'Modules/TemplateEditor/TemplateEditor.js', 'version' => 6 ),
2323 array( 'src' => 'Modules/Templates/Templates.js', 'version' => 1 ),
2424 array( 'src' => 'Modules/AddMediaWizard/AddMediaWizard.js', 'version' => 6 ),
2525 ),
2626 'combined' => array(
27 - array( 'src' => 'WikiEditor.combined.js', 'version' => 119 ),
 27+ array( 'src' => 'WikiEditor.combined.js', 'version' => 120 ),
2828 ),
2929 'minified' => array(
30 - array( 'src' => 'WikiEditor.combined.min.js', 'version' => 119 ),
 30+ array( 'src' => 'WikiEditor.combined.min.js', 'version' => 120 ),
3131 ),
3232 );
3333 static $messages = array(

Status & tagging log