r70107 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70106‎ | r70107 | r70108 >
Date:20:27, 28 July 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Fix function signature. Fails silently in PHP 5.3(.2)

Probably this PHP BUG: http://bugs.php.net/bug.php?id=47554
Modified paths:
  • /trunk/extensions/CleanChanges/Filters.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CleanChanges/Filters.php
@@ -36,7 +36,7 @@
3737 return true;
3838 }
3939
40 - public static function trailer( &$conds, &$tables, &$join_conds, &$opts ) {
 40+ public static function trailer( &$conds, &$tables, &$join_conds, $opts ) {
4141 global $wgRequest;
4242 $opts->add( 'trailer', '' );
4343 $trailer = $wgRequest->getVal( 'trailer' );
@@ -49,7 +49,7 @@
5050 return true;
5151 }
5252
53 - public static function trailerForm( &$items, &$opts ) {
 53+ public static function trailerForm( &$items, $opts ) {
5454 wfLoadExtensionMessages( 'CleanChanges' );
5555
5656 $opts->consumeValue( 'trailer' );

Status & tagging log