r70048 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70047‎ | r70048 | r70049 >
Date:21:43, 27 July 2010
Author:kaldari
Status:ok
Tags:
Comment:
block scoping style per suggestion at r68694 code review
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -452,12 +452,11 @@
453453 $project_langs = array();
454454 $project_langs = $this->getNoticeLanguages( $row->not_name );
455455 $language_count = count( $project_langs );
 456+ $languageList = '';
456457 if ( $language_count > 3 ) {
457458 $languageList = "multiple ($language_count)";
458459 } elseif ( $language_count > 0 ) {
459460 $languageList = implode(', ',$project_langs);
460 - } else {
461 - $languageList = '';
462461 }
463462 $fields[] = $languageList;
464463

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68694handle small numbers of languages better in interface displaykaldari01:21, 29 June 2010

Status & tagging log