r69994 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69993‎ | r69994 | r69995 >
Date:09:36, 27 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Make newFromNode into static method
Modified paths:
  • /trunk/extensions/OAI/OAIHarvest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OAI/OAIHarvest.php
@@ -263,8 +263,6 @@
264264 }
265265 }
266266
267 -
268 -
269267 class OAIUpdateRecord {
270268 var $_page = array();
271269
@@ -610,7 +608,7 @@
611609 /**
612610 * @param DomNode $node
613611 */
614 - function newFromNode( $node ) {
 612+ static function newFromNode( $node ) {
615613 $pageData = OAIUpdateRecord::readRecord( $node );
616614 $record = new OAIUpdateRecord( $pageData );
617615 return $record;

Status & tagging log