r69979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69978‎ | r69979 | r69980 >
Date:22:17, 26 July 2010
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Revert part of r69893, not really globals
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)
  • /trunk/extensions/Translate/ffs/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
——@@ -303,8 +303,6 @@
304304 }
305305
306306 public function getBools() {
307 - global $wgOptionalMessages, $wgIgnoredMessages;
308 -
309307 require( $this->getMetaDataPrefix() . '/messageTypes.inc' );
310308
311309 return array(
Index: trunk/extensions/Translate/ffs/Wiki.php
——@@ -116,8 +116,6 @@
117117
118118 require( $dir . '/messages.inc' );
119119
120 - global $wgMessageStructure, $wgBlockComments;
121 -
122120 # Sort messages to blocks
123121 $sortedMessages['unknown'] = $messages;
124122 foreach ( $wgMessageStructure as $blockName => $block ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69893Add a couple of missing globals...reedy19:22, 25 July 2010

Comments

#Comment by Platonides (talk | contribs)   22:28, 26 July 2010

Marking as fixme non-globals with global name.

#Comment by Nikerabbit (talk | contribs)   22:55, 26 July 2010

It's not this commit that does anything wrong. You should file a bug in bugzilla. However, since we are not going to chance those variable names in 1.15 for example, changing those in trunk now would only complicate things.

#Comment by Reedy (talk | contribs)   06:06, 27 July 2010

So is there much point filing in bugzilla? Won't it just be closed as WONTFIX/similiar?

#Comment by Platonides (talk | contribs)   22:07, 27 July 2010

Mmh, ok. I think we can keep them as is.

Status & tagging log