r69974 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69973‎ | r69974 | r69975 >
Date:21:42, 26 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove some more unused globals/variables
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialMergeAccount.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/ConfirmEdit_body.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/FancyCaptcha.class.php (modified) (history)
  • /trunk/extensions/ConfirmEdit/QuestyCaptcha.class.php (modified) (history)
  • /trunk/extensions/DynamicPageList/DPL.php (modified) (history)
  • /trunk/extensions/DynamicPageList/DPLLogger.php (modified) (history)
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)
  • /trunk/extensions/MWSearch/luceneUpdate.php (modified) (history)
  • /trunk/extensions/SpamBlacklist/cleanup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmEdit/ConfirmEdit_body.php
@@ -738,7 +738,7 @@
739739 * Show a page explaining what this wacky thing is.
740740 */
741741 function showHelp() {
742 - global $wgOut, $ceAllowConfirmedEmail;
 742+ global $wgOut;
743743 $wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
744744 $wgOut->addWikiText( wfMsg( 'captchahelp-text' ) );
745745 if ( $this->storage->cookiesNeeded() ) {
Index: trunk/extensions/ConfirmEdit/QuestyCaptcha.class.php
@@ -57,7 +57,7 @@
5858 }
5959
6060 function showHelp() {
61 - global $wgOut, $ceAllowConfirmedEmail;
 61+ global $wgOut;
6262 $wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
6363 $wgOut->addWikiText( wfMsg( 'questycaptchahelp-text' ) );
6464 if ( $this->storage->cookiesNeeded() ) {
Index: trunk/extensions/ConfirmEdit/FancyCaptcha.class.php
@@ -166,7 +166,7 @@
167167 }
168168
169169 function showImage() {
170 - global $wgOut, $wgRequest;
 170+ global $wgOut;
171171
172172 $wgOut->disable();
173173
Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
@@ -280,7 +280,6 @@
281281 }
282282
283283 fwrite( $sock, $cmd . "\000\000\000" );
284 - $encReponse = '';
285284 while ( $sock && !feof( $sock ) ) {
286285 $encResponse .= fread( $sock, 8192 );
287286 }
Index: trunk/extensions/MWSearch/luceneUpdate.php
@@ -274,7 +274,7 @@
275275 * that might have been missed when the index updater daemon was broken.
276276 */
277277 function rebuildDeleted( $since = null ) {
278 - global $wgDBname, $options;
 278+ global $wgDBname;
279279 $fname = 'LuceneBuilder::rebuildDeleted';
280280
281281 if( is_null( $since ) ) {
Index: trunk/extensions/SpamBlacklist/cleanup.php
@@ -14,7 +14,6 @@
1515 */
1616 function cleanupArticle( $rev, $regexes, $match ) {
1717 $title = $rev->getTitle();
18 - $reverted = false;
1918 $revId = $rev->getId();
2019 while ( $rev ) {
2120 $matches = false;
Index: trunk/extensions/CentralAuth/SpecialMergeAccount.php
@@ -251,7 +251,6 @@
252252 }
253253 $password = $wgRequest->getText( 'wpPassword' );
254254
255 - $home = false;
256255 $attached = array();
257256 $unattached = array();
258257 $ok = $globalUser->attemptPasswordMigration( $password, $attached, $unattached );
Index: trunk/extensions/DynamicPageList/DPL.php
@@ -239,7 +239,6 @@
240240 }
241241
242242 function formatCount( $numart ) {
243 - global $wgLang;
244243 if ( $this->mHeadingType == 'category' ) {
245244 $message = 'categoryarticlecount';
246245 } else {
Index: trunk/extensions/DynamicPageList/DPLLogger.php
@@ -62,7 +62,7 @@
6363 * @return HTML error message
6464 */
6565 function msgWrongParam( $paramvar, $val ) {
66 - global $wgContLang;
 66+
6767 $msgid = DPL_i18n::WARN_WRONGPARAM;
6868 switch( $paramvar ) {
6969 case 'namespace':

Status & tagging log