r69953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69952‎ | r69953 | r69954 >
Date:17:45, 26 July 2010
Author:platonides
Status:deferred
Tags:
Comment:
MFT r69952 + RELEASE-NOTES
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/profileinfo.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/profileinfo.php
@@ -65,7 +65,8 @@
6666 <?php
6767
6868 if ( !$wgEnableProfileInfo ) {
69 - echo "disabled\n";
 69+ echo "<p>Disabled</p>\n";
 70+ echo "</body></html>";
7071 exit( 1 );
7172 }
7273
@@ -251,8 +252,8 @@
252253 if ( $_expand === false )
253254 $_expand = $expand;
254255
255 - $nfilter = $_filter ? $_filter : $filter;
256 - $nsort = $_sort ? $_sort : $sort;
 256+ $nfilter = $_filter ? htmlspecialchars( $_filter ) : htmlspecialchars( $filter );
 257+ $nsort = $_sort ? htmlspecialchars( $_sort ) : htmlspecialchars( $sort );
257258 $exp = urlencode( implode( ',', array_keys( $_expand ) ) );
258259 return "?filter=$nfilter&amp;sort=$nsort&amp;expand=$exp";
259260 }
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -64,6 +64,7 @@
6565 * (bug xxxxx) Fixed Cache-Control headers sent from API modules, to protect
6666 user privacy in the case where an attacker can access the wiki through the
6767 same HTTP proxy as a logged-in user.
 68+* Fixed XSS in profileinfo.php for users with $wgEnableProfileInfo = true;
6869
6970 == Changes since 1.16 beta 2 ==
7071

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69952Close the web page when it is disabled....platonides17:41, 26 July 2010

Status & tagging log