r69936 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69935‎ | r69936 | r69937 >
Date:09:50, 26 July 2010
Author:reedy
Status:deferred
Tags:
Comment:
Fixup per comments to r69894

Restore $key = Xml::escapeJsString( $message->key() );, move into the if, and use $key instead

Restore commented text from TranslatePage.php
Modified paths:
  • /trunk/extensions/Translate/TranslatePage.php (modified) (history)
  • /trunk/extensions/Translate/ffs/OpenLayers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslatePage.php
@@ -193,10 +193,10 @@
194194 protected function settingsForm( $errors ) {
195195 global $wgScript;
196196
197 - //$task = $this->taskSelector();
198 - //$group = $this->groupSelector();
199 - //$language = $this->languageSelector();
200 - //$limit = $this->limitSelector();
 197+ $task = $this->taskSelector();
 198+ $group = $this->groupSelector();
 199+ $language = $this->languageSelector();
 200+ $limit = $this->limitSelector();
201201 $button = Xml::submitButton( wfMsg( TranslateUtils::MSG . 'submit' ) );
202202
203203 $options = array();
Index: trunk/extensions/Translate/ffs/OpenLayers.php
@@ -159,7 +159,8 @@
160160 foreach ( $collection as $message ) {
161161 $value = Xml::escapeJsString( $message->translation() );
162162 if( $this->keyquote ) {
163 - $lines .= " '{$message->key()}': \"{$value}\",\n\n";
 163+ $key = Xml::escapeJsString( $message->key() );
 164+ $lines .= " '{$key}': \"{$value}\",\n\n";
164165 } else {
165166 $lines .= " {$message->key()}: \"{$value}\",\n\n";
166167 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69894Fix some more unused stuffreedy19:32, 25 July 2010

Status & tagging log