r69933 MediaWiki - Code Review archive

The problem is that the query that produces the authors list has LIMIT 500, so eventually this number will be incorrect.

Additionally, you should use $wgLang->formatNum() to display numbers.

Does that list paginate at all? As if not, that's a problem also.. (I'm guessing it doesn't)

mysql> SELECT COUNT(ca_author) FROM code_authors WHERE ca_repo_id = 1; +------------------+ | COUNT(ca_author) | +------------------+ | 200 | +------------------+ 1 row in set (0.00 sec)

Though, I've noticed that isn't populated on my test install...

We could query that, and cache for a similar length as the user list...?

Also, what about:

	public function getAuthorCount() {
		global $wgMemc;
		$key = wfMemcKey( 'codereview', 'authorcount', $this->getId() );
		$authorsCount = $wgMemc->get( $key );
		if ( is_int( $authorsCount ) ) {
			return $authorsCount;
		}
		$dbr = wfGetDB( DB_SLAVE );
		$res = $dbr->select(
			'code_authors',
			array( 'COUNT(cr_author) AS author_count' ),
			array( 'cr_repo_id' => $this->getId() ),
			__METHOD__,
		);

		if ( !$row ) {
			throw new MWException( 'Failed to load expected author count' );
		}
		
		$authorcount = $row->author_count;
		
		$wgMemc->set( $key, $authorcount, 3600 * 24 );
		return $authorcount;
	}

Though, the code_authors only seems to be populated at point of linking... :/

SELECT COUNT(DISTINCT cr_author) FROM mw_code_rev;

is the other option. But I bet it's unindexed, and will make domas unhappy

mysql> DESCRIBE SELECT COUNT(DISTINCT cr_author) FROM mw_code_rev;
+----+-------------+-------------+-------+---------------+----------------+---------+------+-------+-------------+
| id | select_type | table       | type  | possible_keys | key            | key_len | ref  | rows  | Extra       |
+----+-------------+-------------+-------+---------------+----------------+---------+------+-------+-------------+
|  1 | SIMPLE      | mw_code_rev | index | NULL          | cr_repo_author | 276     | NULL | 80602 | Using index |
+----+-------------+-------------+-------+---------------+----------------+---------+------+-------+-------------+
1 row in set (0.00 sec)

Write a maintenance script that populates code_authors from code_rev with ca_user_text = NULL

Noticed what I posted above was wrong (mix of $res and $row), but blah

code_authors is only for the ones that have been linked.

Could probably ditch the LIMIT 500, we've got an index on this.