r69885 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69884‎ | r69885 | r69886 >
Date:18:03, 25 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Many self:: to $this-> in HttpTest
Modified paths:
  • /trunk/phase3/maintenance/tests/HttpTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/HttpTest.php
@@ -125,7 +125,7 @@
126126
127127 function testFailureDefault() {
128128 Http::$httpEngine = false;
129 - self::runHTTPFailureChecks();
 129+ $this->runHTTPFailureChecks();
130130 }
131131
132132 function testFailurePhp() {
@@ -134,7 +134,7 @@
135135 }
136136
137137 Http::$httpEngine = "php";
138 - self::runHTTPFailureChecks();
 138+ $this->runHTTPFailureChecks();
139139 }
140140
141141 function testFailureCurl() {
@@ -143,7 +143,7 @@
144144 }
145145
146146 Http::$httpEngine = "curl";
147 - self::runHTTPFailureChecks();
 147+ $this->runHTTPFailureChecks();
148148 }
149149
150150 /* ./phase3/includes/Import.php:1108: $data = Http::request( $method, $url ); */
@@ -167,7 +167,7 @@
168168
169169 function testRequestDefault() {
170170 Http::$httpEngine = false;
171 - self::runHTTPRequests();
 171+ $this->runHTTPRequests();
172172 }
173173
174174 function testRequestPhp() {
@@ -176,7 +176,7 @@
177177 }
178178
179179 Http::$httpEngine = "php";
180 - self::runHTTPRequests();
 180+ $this->runHTTPRequests();
181181 }
182182
183183 function testRequestCurl() {
@@ -185,7 +185,7 @@
186186 }
187187
188188 Http::$httpEngine = "curl";
189 - self::runHTTPRequests();
 189+ $this->runHTTPRequests();
190190 }
191191
192192 /* ./extensions/SpamBlacklist/SpamBlacklist_body.php:164: $httpText = Http::get( $fileName ); */
@@ -249,7 +249,7 @@
250250
251251 function testGetDefault() {
252252 Http::$httpEngine = false;
253 - self::runHTTPGets();
 253+ $this->runHTTPGets();
254254 }
255255
256256 function testGetPhp() {
@@ -258,7 +258,7 @@
259259 }
260260
261261 Http::$httpEngine = "php";
262 - self::runHTTPGets();
 262+ $this->runHTTPGets();
263263 }
264264
265265 function testGetCurl() {
@@ -267,7 +267,7 @@
268268 }
269269
270270 Http::$httpEngine = "curl";
271 - self::runHTTPGets();
 271+ $this->runHTTPGets();
272272 }
273273
274274 /* ./phase3/maintenance/parserTests.inc:1618: return Http::post( $url, array( 'postData' => wfArrayToCGI( $data ) ) ); */
@@ -290,7 +290,7 @@
291291
292292 function testPostDefault() {
293293 Http::$httpEngine = false;
294 - self::runHTTPPosts();
 294+ $this->runHTTPPosts();
295295 }
296296
297297 function testPostPhp() {
@@ -299,7 +299,7 @@
300300 }
301301
302302 Http::$httpEngine = "php";
303 - self::runHTTPPosts();
 303+ $this->runHTTPPosts();
304304 }
305305
306306 function testPostCurl() {
@@ -308,26 +308,26 @@
309309 }
310310
311311 Http::$httpEngine = "curl";
312 - self::runHTTPPosts();
 312+ $this->runHTTPPosts();
313313 }
314314
315315 function runProxyRequests() {
316316 if ( !self::$has_proxy ) {
317317 $this->markTestIncomplete( "This test requires a proxy." );
318318 }
319 - self::runHTTPGets( self::$proxy );
320 - self::runHTTPPosts( self::$proxy );
321 - self::runHTTPRequests( self::$proxy );
 319+ $this->runHTTPGets( self::$proxy );
 320+ $this->runHTTPPosts( self::$proxy );
 321+ $this->runHTTPRequests( self::$proxy );
322322
323323 // Set false here to do noProxy
324 - self::runHTTPGets( false );
325 - self::runHTTPPosts( false );
326 - self::runHTTPRequests( false );
 324+ $this->runHTTPGets( false );
 325+ $this->runHTTPPosts( false );
 326+ $this->runHTTPRequests( false );
327327 }
328328
329329 function testProxyDefault() {
330330 Http::$httpEngine = false;
331 - self::runProxyRequests();
 331+ $this->runProxyRequests();
332332 }
333333
334334 function testProxyPhp() {
@@ -336,7 +336,7 @@
337337 }
338338
339339 Http::$httpEngine = 'php';
340 - self::runProxyRequests();
 340+ $this->runProxyRequests();
341341 }
342342
343343 function testProxyCurl() {
@@ -345,7 +345,7 @@
346346 }
347347
348348 Http::$httpEngine = 'curl';
349 - self::runProxyRequests();
 349+ $this->runProxyRequests();
350350 }
351351
352352 function testIsLocalUrl() {
@@ -546,7 +546,7 @@
547547
548548 function testCookieRequestDefault() {
549549 Http::$httpEngine = false;
550 - self::runCookieRequests();
 550+ $this->runCookieRequests();
551551 }
552552 function testCookieRequestPhp() {
553553 if ( !self::$has_fopen ) {
@@ -554,7 +554,7 @@
555555 }
556556
557557 Http::$httpEngine = 'php';
558 - self::runCookieRequests();
 558+ $this->runCookieRequests();
559559 }
560560 function testCookieRequestCurl() {
561561 if ( !self::$has_curl ) {
@@ -562,6 +562,6 @@
563563 }
564564
565565 Http::$httpEngine = 'curl';
566 - self::runCookieRequests();
 566+ $this->runCookieRequests();
567567 }
568568 }

Status & tagging log