r69868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69867‎ | r69868 | r69869 >
Date:11:31, 25 July 2010
Author:ialex
Status:ok
Tags:
Comment:
Per Simetrical, fix for r69499: only select the fields used by Title::newFromRow()
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -219,8 +219,15 @@
220220 }
221221 $dbr = wfGetDB( DB_SLAVE );
222222
223 - $res = $dbr->select( 'page', array( '*' ),
224 - array( 'page_id' => $ids ), __METHOD__ );
 223+ $res = $dbr->select(
 224+ 'page',
 225+ array(
 226+ 'page_namespace', 'page_title', 'page_id',
 227+ 'page_len', 'page_is_redirect', 'page_latest',
 228+ ),
 229+ array( 'page_id' => $ids ),
 230+ __METHOD__
 231+ );
225232
226233 $titles = array();
227234 foreach ( $res as $row ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69499Let Title::newFromIDs() select all fields and use Title::newFromRow() since w...ialex09:36, 18 July 2010

Status & tagging log