r69856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69855‎ | r69856 | r69857 >
Date:23:21, 24 July 2010
Author:platonides
Status:reverted
Tags:
Comment:
Fix the function comments. This used to be right until r13689.
4 years and 3 months after, and near to deprecation, it is fixed.
Modified paths:
  • /branches/REL1_15/phase3/skins/common/edit.js (modified) (history)

Diff [purge]

Index: branches/REL1_15/phase3/skins/common/edit.js
@@ -1,5 +1,4 @@
2 -// this function generates the actual toolbar buttons with localized text
3 -// we use it to avoid creating the toolbar where javascript is not enabled
 2+// this function adds a toolbar button to the mwEditButtons list
43 function addButton(imageFile, speedTip, tagOpen, tagClose, sampleText, imageId) {
54 // Don't generate buttons for browsers which don't fully
65 // support it.
@@ -12,8 +11,7 @@
1312 "sampleText": sampleText};
1413 }
1514
16 -// this function generates the actual toolbar buttons with localized text
17 -// we use it to avoid creating the toolbar where javascript is not enabled
 15+// this function adds one toolbar butto from a mwEditButtons/mwCustomEditButtons item
1816 function mwInsertEditButton(parent, item) {
1917 var image = document.createElement("img");
2018 image.width = 23;
@@ -34,6 +32,8 @@
3533 return true;
3634 }
3735
 36+// this function generates the actual toolbar buttons with localized text
 37+// we use it to avoid creating the toolbar where javascript is not enabled
3838 function mwSetupToolbar() {
3939 var toolbar = document.getElementById('toolbar');
4040 if (!toolbar) { return false; }

Follow-up revisions

RevisionCommit summaryAuthorDate
r69857Revert r69856. This was intended for trunk.platonides23:28, 24 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r13689* (bug 4663) Edit toolbar enabled in compatible versions of Safari...brion10:36, 17 April 2006

Status & tagging log