r69847 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69846‎ | r69847 | r69848 >
Date:21:11, 24 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove unused variable

Remove 1 unused global
Modified paths:
  • /trunk/phase3/includes/Licenses.php (modified) (history)
  • /trunk/phase3/maintenance/mergeMessageFileList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/mergeMessageFileList.php
@@ -16,7 +16,7 @@
1717 }
1818
1919 public function execute() {
20 - global $IP, $mmfl;
 20+ global $mmfl;
2121 if ( !$this->hasOption( 'list-file' ) ) {
2222 $this->error( 'The --list-file option must be specified.' );
2323 return;
Index: trunk/phase3/includes/Licenses.php
@@ -69,8 +69,6 @@
7070 }
7171
7272 protected function trimStars( $str ) {
73 - $i = $count = 0;
74 -
7573 $numStars = strspn( $str, '*' );
7674 return array( $numStars, ltrim( substr( $str, $numStars ), ' ' ) );
7775 }

Status & tagging log