r69843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69842‎ | r69843 | r69844 >
Date:20:12, 24 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove unused globals
Modified paths:
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -131,7 +131,7 @@
132132 }
133133
134134 function sysLinks() {
135 - global $wgUser, $wgLang, $wgContLang;
 135+ global $wgUser, $wgLang;
136136 $li = SpecialPage::getTitleFor( 'Userlogin' );
137137 $lo = SpecialPage::getTitleFor( 'Userlogout' );
138138
@@ -190,7 +190,7 @@
191191 * @access private
192192 */
193193 function quickBar(){
194 - global $wgOut, $wgUser, $wgEnableUploads;
 194+ global $wgOut, $wgUser;
195195
196196 $tns = $this->mTitle->getNamespace();
197197
Index: trunk/phase3/skins/Standard.php
@@ -103,7 +103,6 @@
104104
105105 function quickBar() {
106106 global $wgOut, $wgUser, $wgRequest, $wgContLang;
107 - global $wgEnableUploads, $wgRemoteUploads;
108107
109108 wfProfileIn( __METHOD__ );
110109
Index: trunk/phase3/skins/Vector.php
@@ -367,7 +367,7 @@
368368 * Outputs the entire contents of the XHTML page
369369 */
370370 public function execute() {
371 - global $wgRequest, $wgOut, $wgContLang;
 371+ global $wgRequest, $wgContLang;
372372
373373 $this->skin = $this->data['skin'];
374374 $action = $wgRequest->getText( 'action' );
@@ -675,7 +675,7 @@
676676 * when UI is in RTL mode
677677 */
678678 private function renderNavigation( $elements ) {
679 - global $wgContLang, $wgVectorUseSimpleSearch, $wgVectorShowVariantName, $wgUser;
 679+ global $wgVectorUseSimpleSearch, $wgVectorShowVariantName, $wgUser;
680680
681681 // If only one element was given, wrap it in an array, allowing more
682682 // flexible arguments
Index: trunk/phase3/skins/Nostalgia.php
@@ -57,7 +57,7 @@
5858 }
5959
6060 function topLinks() {
61 - global $wgOut, $wgUser, $wgEnableUploads;
 61+ global $wgOut, $wgUser;
6262 $sep = " |\n";
6363
6464 $s = $this->mainPageLink() . $sep
Index: trunk/phase3/skins/Modern.php
@@ -31,8 +31,6 @@
3232 }
3333
3434 function setupSkinUserCss( OutputPage $out ){
35 - global $wgStyleVersion, $wgJsMimeType, $wgStylePath;
36 -
3735 // Do not call parent::setupSkinUserCss(), we have our own print style
3836 $out->addStyle( 'common/shared.css', 'screen' );
3937 $out->addStyle( 'modern/main.css', 'screen' );
@@ -56,7 +54,7 @@
5755 * @access private
5856 */
5957 function execute() {
60 - global $wgRequest, $wgOut;
 58+ global $wgRequest;
6159 $this->skin = $skin = $this->data['skin'];
6260 $action = $wgRequest->getText( 'action' );
6361

Status & tagging log