r69813 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69812‎ | r69813 | r69814 >
Date:20:35, 23 July 2010
Author:reedy
Status:ok
Tags:
Comment:
$title undefined in initialize

Guessing it's supposed to be $this->mTitle
Modified paths:
  • /trunk/phase3/includes/Category.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Category.php
@@ -25,8 +25,9 @@
2626 * @return bool True on success, false on failure.
2727 */
2828 protected function initialize() {
29 - if ( $this->mName === null && $this->mTitle )
30 - $this->mName = $title->getDBkey();
 29+ if ( $this->mName === null && $this->mTitle ) {
 30+ $this->mName = $this->mTitle->getDBkey();
 31+ }
3132
3233 if ( $this->mName === null && $this->mID === null ) {
3334 throw new MWException( __METHOD__ . ' has both names and IDs null' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r70030Remove dead code added in r36814...simetrical19:55, 27 July 2010

Status & tagging log