r69798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69797‎ | r69798 | r69799 >
Date:16:36, 23 July 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove/comment out some unused globals from CodeReview
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRepoStatsView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeStatusChangeListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -159,7 +159,7 @@
160160 $wgHooks['LoadExtensionSchemaUpdates'][] = 'efCodeReviewSchemaUpdates';
161161
162162 function efCodeReviewSchemaUpdates() {
163 - global $wgDBtype, $wgExtNewFields, $wgExtPGNewFields, $wgExtNewIndexes, $wgExtNewTables, $wgExtModifiedFields;
 163+ global $wgDBtype, $wgExtNewFields, /*$wgExtPGNewFields,*/ $wgExtNewIndexes, $wgExtNewTables, $wgExtModifiedFields;
164164 $base = dirname( __FILE__ );
165165 if ( $wgDBtype == 'mysql' ) {
166166 $wgExtNewTables[] = array( 'code_rev', "$base/codereview.sql" ); // Initial install tables
Index: trunk/extensions/CodeReview/ui/CodeRepoStatsView.php
@@ -9,7 +9,7 @@
1010 }
1111
1212 function execute() {
13 - global $wgOut, $wgLang, $wgSkin;
 13+ global $wgOut, $wgLang;
1414
1515 $stats = RepoStats::newFromRepo( $this->mRepo );
1616 $repoName = $this->mRepo->getName();
Index: trunk/extensions/CodeReview/ui/CodeStatusChangeListView.php
@@ -62,7 +62,7 @@
6363 }
6464
6565 function formatValue( $name, $value ) {
66 - global $wgUser, $wgLang;
 66+ global $wgLang;
6767 switch( $name ) {
6868 case 'cpc_rev_id':
6969 return $this->mView->mSkin->link(

Status & tagging log