r69768 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69767‎ | r69768 | r69769 >
Date:00:07, 23 July 2010
Author:mah
Status:ok
Tags:
Comment:
re r64403 - remove never-actually-used $flag parameter from verifyUpload()
Modified paths:
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiUpload.php
@@ -156,12 +156,9 @@
157157
158158 /**
159159 * Performs file verification, dies on error.
160 - *
161 - * @param $flag integer passed to UploadBase::verifyUpload, set to
162 - * UploadBase::EMPTY_FILE to skip the empty file check.
163160 */
164 - public function verifyUpload( $flag ) {
165 - $verification = $this->mUpload->verifyUpload( $flag );
 161+ public function verifyUpload( ) {
 162+ $verification = $this->mUpload->verifyUpload( );
166163 if ( $verification['status'] === UploadBase::OK ) {
167164 return $verification;
168165 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64403* Set $titleObj to null by default on getWatchlistValue since it often isn't ...mah19:10, 30 March 2010

Status & tagging log