r69727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69726‎ | r69727 | r69728 >
Date:13:04, 22 July 2010
Author:demon
Status:ok
Tags:
Comment:
Fix r69229. This should not be abstract, return dummy in parent
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -2354,12 +2354,14 @@
23552355 }
23562356
23572357 /**
2358 - * Get search engine class. Subclasses that don't support a search engine
2359 - * should return 'SearchEngineDummy'.
 2358+ * Get search engine class. All subclasses of this need to implement this
 2359+ * if they wish to use searching.
23602360 *
23612361 * @return String
23622362 */
2363 - public abstract function getSearchEngine();
 2363+ public function getSearchEngine() {
 2364+ return 'SearchEngineDummy';
 2365+ }
23642366
23652367 /**
23662368 * Allow or deny "big selects" for this session only. This is done by setting

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69229Fixed mysqlisms in Database.php comments, abstracted getSearchEngine()maxsem10:15, 10 July 2010

Status & tagging log