r69676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69675‎ | r69676 | r69677 >
Date:13:20, 21 July 2010
Author:catrope
Status:deferred
Tags:
Comment:
resourceloader: Make CSSJanus::transform() static, as it was intended to be. Fix the profiling name and Doxygen comment in load.php
Modified paths:
  • /branches/resourceloader/phase3/includes/CSSJanus.php (modified) (history)
  • /branches/resourceloader/phase3/load.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/CSSJanus.php
@@ -123,7 +123,7 @@
124124 * @param bool $swapLeftRightInURL If true, swap 'left' and 'right' in URLs
125125 * @return Transformed stylesheet
126126 */
127 - public function transform( $css, $swapLtrRtlInURL = false, $swapLeftRightInURL = false ) {
 127+ public static function transform( $css, $swapLtrRtlInURL = false, $swapLeftRightInURL = false ) {
128128 // We wrap tokens in ` , not ~ like the original implementation does.
129129 // This was done because ` is not a legal character in CSS and can only
130130 // occur in URLs, where we escape it to %60 before inserting our tokens.
Index: branches/resourceloader/phase3/load.php
@@ -21,13 +21,14 @@
2222 */
2323
2424 /**
 25+ * @file
2526 * This file is the entry point for the resource loader.
2627 */
2728
2829 // TODO: Caching + easy 304s before WebStart
2930
3031 require ( dirname( __FILE__ ) . '/includes/WebStart.php' );
31 -wfProfileIn( 'loader.php' );
 32+wfProfileIn( 'load.php' );
3233
3334 // URL safety checks
3435 //
@@ -51,7 +52,7 @@
5253 // Respond to resource loading request
5354 ResourceLoader::respond( $wgRequest );
5455
55 -wfProfileOut( 'loader.php' );
 56+wfProfileOut( 'load.php' );
5657 wfLogProfilingData();
5758
5859 // Shut down the database

Status & tagging log