r69631 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69630‎ | r69631 | r69632 >
Date:16:14, 20 July 2010
Author:mah
Status:ok
Tags:
Comment:
fixes r69333 — remove dependency on iconv, use icu or native only
Modified paths:
  • /trunk/phase3/includes/normal/UtfNormal.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/normal/UtfNormal.php
@@ -73,13 +73,6 @@
7474 * @return string a clean, shiny, normalized UTF-8 string
7575 */
7676 static function cleanUp( $string ) {
77 - if( extension_loaded( 'iconv' ) ) {
78 - wfSuppressWarnings();
79 - $ret = iconv( "UTF-8","UTF-8//IGNORE", $string );
80 - wfRestoreWarnings();
81 - return $ret;
82 - }
83 -
8477 if( NORMALIZE_ICU || NORMALIZE_INTL ) {
8578 # We exclude a few chars that ICU would not.
8679 $string = preg_replace(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69333* revert r61258...mah17:34, 14 July 2010

Status & tagging log