r69616 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69615‎ | r69616 | r69617 >
Date:14:49, 20 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed PHP strict standards issue
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php
@@ -516,7 +516,8 @@
517517 $log = array_merge( $log, $prunelog );
518518 $maxdepth = $newdepth;
519519 if ( count( $result->getDescriptions() ) == 1 ) { // simplify unary conjunctions!
520 - $result = array_shift( $result->getDescriptions() );
 520+ $descriptions = $result->getDescriptions();
 521+ $result = array_shift( $descriptions );
521522 }
522523 $result->setPrintRequests( $this->getPrintRequests() );
523524 return $result;
@@ -664,7 +665,8 @@
665666 $log = array_merge( $log, $prunelog );
666667 $maxdepth = $newdepth;
667668 if ( count( $result->getDescriptions() ) == 1 ) { // simplify unary disjunctions!
668 - $result = array_shift( $result->getDescriptions() );
 669+ $descriptions = $result->getDescriptions();
 670+ $result = array_shift( $descriptions );
669671 }
670672 $result->setPrintRequests( $this->getPrintRequests() );
671673 return $result;
@@ -748,5 +750,4 @@
749751 $result->setPrintRequests( $this->getPrintRequests() );
750752 return $result;
751753 }
752 -}
753 -
 754+}
\ No newline at end of file

Status & tagging log