r69603 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69602‎ | r69603 | r69604 >
Date:11:27, 20 July 2010
Author:jeroendedauw
Status:ok
Tags:
Comment:
Clarified field and method visibility and added TODOs
Modified paths:
  • /trunk/phase3/includes/installer/OracleInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/OracleInstaller.php
@@ -15,7 +15,7 @@
1616 '_InstallPassword' => '',
1717 );
1818
19 - function getName() {
 19+ public function getName() {
2020 return 'oracle';
2121 }
2222
@@ -23,7 +23,7 @@
2424 return self::checkExtension( 'oci8' );
2525 }
2626
27 - function getConnectForm() {
 27+ public function getConnectForm() {
2828 return
2929 Xml::openElement( 'fieldset' ) .
3030 Xml::element( 'legend', array(), wfMsg( 'config-db-wiki-settings' ) ) .
@@ -35,7 +35,7 @@
3636 $this->getInstallUserBox();
3737 }
3838
39 - function submitConnectForm() {
 39+ public function submitConnectForm() {
4040 // Get variables from the request
4141 $newValues = $this->setVarsFromRequest( array( 'wgDBname', 'wgDBprefix' ) );
4242
@@ -77,20 +77,31 @@
7878 }
7979
8080
81 - function getSettingsForm() {}
 81+ public function getSettingsForm() {
 82+ // TODO
 83+ }
8284
83 - function submitSettingsForm() {}
 85+ public function submitSettingsForm() {
 86+ // TODO
 87+ }
8488
85 - function getConnection() {}
 89+ public function getConnection() {
 90+ // TODO
 91+ }
8692
87 - function setupDatabase() {}
 93+ public function setupDatabase() {
 94+ // TODO
 95+ }
8896
89 - function createTables() {}
 97+ public function createTables() {
 98+ // TODO
 99+ }
90100
91 - function getLocalSettings() {
 101+ public function getLocalSettings() {
92102 $prefix = $this->getVar( 'wgDBprefix' );
93103 return
94104 "# Oracle specific settings
95105 \$wgDBprefix = \"{$prefix}\";";
96106 }
97 -}
 107+
 108+}
\ No newline at end of file

Status & tagging log