r69583 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69582‎ | r69583 | r69584 >
Date:07:05, 20 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed non-static method that should have been static
Modified paths:
  • /trunk/extensions/Maps/ParserFunctions/Maps_GeoFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/ParserFunctions/Maps_GeoFunctions.php
@@ -51,9 +51,11 @@
5252 * Handler for the #geodistance parser function.
5353 * See http://mapping.referata.com/wiki/Geodistance
5454 *
 55+ * @since 0.6
 56+ *
5557 * @param Parser $parser
5658 */
57 - function renderGeoDistance( Parser &$parser ) {
 59+ public static function renderGeoDistance( Parser &$parser ) {
5860 global $egMapsDistanceUnit, $egMapsDistanceDecimals;
5961
6062 $args = func_get_args();
@@ -143,6 +145,8 @@
144146 * Handler for the #finddestination parser function.
145147 * See http://mapping.referata.com/wiki/Finddestination
146148 *
 149+ * @since 0.6
 150+ *
147151 * @param Parser $parser
148152 */
149153 public static function renderFindDestination( Parser &$parser ) {
@@ -252,6 +256,8 @@
253257 * Returns the geographical distance between two coordinates.
254258 * See http://en.wikipedia.org/wiki/Geographical_distance
255259 *
 260+ * @since 0.6
 261+ *
256262 * @param array $start The first coordinates, as non-directional floats in an array with lat and lon keys.
257263 * @param array $end The second coordinates, as non-directional floats in an array with lat and lon keys.
258264 *
@@ -288,6 +294,8 @@
289295 /**
290296 * Finds a destination given a starting location, bearing and distance.
291297 *
 298+ * @since 0.6
 299+ *
292300 * @param array $startingCoordinates The starting coordinates, as non-directional floats in an array with lat and lon keys.
293301 * @param float $bearing The initial bearing in degrees.
294302 * @param float $distance The distance to travel in km.

Status & tagging log