r69566 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69565‎ | r69566 | r69567 >
Date:19:52, 19 July 2010
Author:adam
Status:ok
Tags:
Comment:
HightlightText - improving a conditional based on Roan's comment on r69483
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.highlightText.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -86,7 +86,7 @@
8787 array( 'src' => 'js/plugins.combined.js', 'version' => 452 ),
8888 ),
8989 'minified' => array(
90 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 469 ),
 90+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 470 ),
9191 ),
9292 ),
9393 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.highlightText.js
@@ -41,7 +41,7 @@
4242 }
4343 // if this is an element with childnodes, and not a script, style or an element we created
4444 } else if ( node.nodeType == 1 && node.childNodes && !/(script|style)/i.test( node.tagName )
45 - && !( node.tagName.toLowerCase() == 'span' && node.className.match( 'highlight' ) ) ) {
 45+ && !( node.tagName.toLowerCase() == 'span' && node.className.match( /\bhighlight/ ) ) ) {
4646 for ( var i = 0; i < node.childNodes.length; ++i ) {
4747 // call the highlight function for each child node
4848 $.highlightText.innerHighlight( node.childNodes[i], pat );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69483Follow up to r69165. Removing a use of the classlist apiadam17:23, 17 July 2010

Status & tagging log