r69461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69460‎ | r69461 | r69462 >
Date:02:24, 17 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69460
Modified paths:
  • /trunk/extensions/Maps/test/MapsCoordinateParserTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/test/MapsCoordinateParserTest.php
@@ -200,7 +200,7 @@
201201 $this->assertFalse( MapsCoordinateParser::areFloatCoordinates( $coord ), "$coord was recognized as dms." );
202202 }
203203 foreach( self::$coordinates['dms'] as $coord ) {
204 - $this->assertEquals( Maps_COORDS_FLOAT, MapsCoordinateParser::getCoordinatesType( $coord ), "$coord not recognized as dms." );
 204+ $this->assertEquals( Maps_COORDS_DMS, MapsCoordinateParser::getCoordinatesType( $coord ), "$coord not recognized as dms." );
205205 }
206206 }
207207
@@ -212,7 +212,7 @@
213213 $this->assertFalse( MapsCoordinateParser::areFloatCoordinates( $coord ), "$coord was recognized as dd." );
214214 }
215215 foreach( self::$coordinates['dd'] as $coord ) {
216 - $this->assertEquals( Maps_COORDS_FLOAT, MapsCoordinateParser::getCoordinatesType( $coord ), "$coord not recognized as dd." );
 216+ $this->assertEquals( Maps_COORDS_DD, MapsCoordinateParser::getCoordinatesType( $coord ), "$coord not recognized as dd." );
217217 }
218218 }
219219
@@ -224,7 +224,7 @@
225225 $this->assertFalse( MapsCoordinateParser::areFloatCoordinates( $coord ), "$coord was recognized as dm." );
226226 }
227227 foreach( self::$coordinates['dm'] as $coord ) {
228 - $this->assertEquals( Maps_COORDS_FLOAT, MapsCoordinateParser::getCoordinatesType( $coord ), "$coord not recognized as dm." );
 228+ $this->assertEquals( Maps_COORDS_DM, MapsCoordinateParser::getCoordinatesType( $coord ), "$coord not recognized as dm." );
229229 }
230230 }
231231

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69460Added more unit testsjeroendedauw02:15, 17 July 2010

Status & tagging log